Limit update rate to 1 frame.

evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft

https://rclootcouncil.com

GNU Lesser General Public License v3.0

19 stars 29 forks source link

Limit update rate to 1 frame. #137

Closed SafeteeWoW closed 6 years ago

SafeteeWoW commented 6 years ago

After the most recent Curseforge report, I realize 0.2s update interval is not good, especially when switching session. Therefore, the update rate is changed to every frame.

evil-morfar commented 6 years ago

The idea behind 0.2 sec was to not have too many Updates in a short period of time. I don't think several responses/lootAcks comes in within a single frame, so this change basically reverts the Update function back to when there wasn't a check.

Also, why should the 0.2s be bad?

SafeteeWoW commented 6 years ago

With 0.2s delay, there is a visual delay when switching session with filter enabled? Can you fix that?

SafeteeWoW commented 6 years ago

And can you have a look at #122? Since the major bugs have been cleared, can you merge that in the next version?

evil-morfar commented 6 years ago

Yes, that's pretty easy. 254471ab38a58169837d6abd632b2e48477eafd2

There's no reason to make the same comment multiple places.