Show item bonus text - Githubissues

evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft

https://rclootcouncil.com

GNU Lesser General Public License v3.0

19 stars 29 forks source link

Show item bonus text #144

Closed SafeteeWoW closed 6 years ago

SafeteeWoW commented 6 years ago

The item bonus text(socket/leech/avoidance/speed/indestructible) is now shown in session frame, loot frame and the voting frame.
The item state text in the voting frame (green text such as "Mythic Warforged") is removed. One reason is that the item state text is too far right when item bonus is shown with the ilvl. The other reason is that item state is not sth really needed. Everyone can know whether an item is warforged/titanforged according to its ilvl.
I have used this PR as ML for two weeks without a problem.

evil-morfar commented 6 years ago

While one could argue "Heroic" and "Mythic" tags are redundant, I very much like the Warforged/Titanforged strings, and consider it a feature that shouldn't be removed. I think there's several alternatives to make room for the new indicators, including resizing and color changes that could make it fit nicely. I'll play around with it and see what I like best. Feel free to give a suggestion though.

I'm also not sure if I like the position in the session frame.

evil-morfar commented 6 years ago

I think this is a bit cleaner, but your thoughts are welcome.

And probably one of the worst cases:

LootFrame:

Session setup:

I'm considering not showing it in the session frame, as I don't think it looks particularly good, and I can't find a way to make it look good.