search

evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

Show out of instance in voting frame #158

Closed SafeteeWoW closed 6 years ago

SafeteeWoW commented 6 years ago

Only done LUA syntax check. Haven't run in-game. Missing localization entry. I have talked about this in #155

I am considering to put "Out of instance" in the response column instead of name column.

SafeteeWoW commented 6 years ago
  1. I have moved the text to the end of response
  2. GROUP_ROSTER_UPDATE does not work. Instead. UNIT_PHASE fires whenever any other group members enter/exit an instance. ZONE_CHANGED_NEW_AREA fires when the current player enter/exit an instance.
  3. Tested in game. My tests shows that UnitPosition returns the correct result immediately after UNIT_PHASE or ZONE_CHANGED_NEW_AREA. (Multiple UNIT_PHASE could fire for the same unit if there are multiple unitID for it, for example "target", "nameplate1", "party1". UnitPosition returns the correct result immediately after the end of last one of these events). So does ZONE_CHANGED_NEW_AREA
  4. Localization entry is added. This PR is complete.
SafeteeWoW commented 6 years ago

This feature could be in v2.10