evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

Clearer item loot dialog choices (yes/no -> keep/trade) #183

Closed Hoishin closed 4 years ago

Hoishin commented 4 years ago

After looting bosses, our guild have a repeated problem of accidentally selecting Yes when they don't want keep the item, or vice versa. They have to tell the raid leader that they didn't mean it after that and manually count it for rolls.

The problem here is that the choice isn't really matter of saying yes and no, but rather they choose if they want to keep it or trade it.

This PR makes the dialog clearer by changing the choices "Keep" and "Trade", minimizing the possibility of such errors.

evil-morfar commented 4 years ago

Just FYI, this doesn't work as it's missing the translation phrase you've altered.

Hoishin commented 4 years ago

Should be fixed