search

evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

Time zone differences not accounted for #187

Open mcd8604 opened 4 years ago

mcd8604 commented 4 years ago

I noticed tonight that the history timestamps are saved based on the master looter's timezone. We ran two raids tonight and changed master looter. The second ML happened to have an earlier timezone and the gear drops got interspersed with the prior raid:

rclootcouncil_timestamp_issue The two highlighted items were from BWL and the items in between came from MC which we ran an hour later.

Is it possible to save the timezone along with the timestamp?

evil-morfar commented 4 years ago

I'm working on revamping the time system. I'm treading carefully as it could have some backwards compatibility issues, but I'll most likely change all awards to be based on server time.

Orphis commented 4 years ago

When you do that, make sure to use an ISO format for dates, dd/mm/yy is totally ambiguous when you try to import it in any software and doesn't sort nicely. YYYY-MM-DD works better. Also, there's no reason to not have the time in the same field for even easier sorting: YYYY-MM-DDThh:mm:ss

johnbaker commented 3 weeks ago

I've run into this in an external app I am working on that is based on RCLootCouncil exports. The exported timestamps would be more useful they were based on server time or if the timezone information was included with the export.