evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

3.0.0-Beta1 still same errors as in 3.0.0-Alpha6 #197

Closed s3thus closed 4 years ago

s3thus commented 4 years ago

after /rc test - no window:

5x RCLootCouncil\Modules\votingFrame.lua:1334: attempt to index field '?' (a nil value)
[string "@RCLootCouncil\Modules\votingFrame.lua"]:1334: in function `Filter'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:443: in function `DoFilter'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:339: in function `SortData'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:592: in function `SetData'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:691: in function `BuildST'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:349: in function `Setup'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:216: in function `ReceiveLootTable'
[string "@RCLootCouncil\core.lua"]:2563: in function `OnLootTableReceived'
[string "@RCLootCouncil\core.lua"]:2431: in function `_onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Observer.lua"]:30: in function `onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Subjects\Subject.lua"]:57: in function `next'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:163: in function `FireCmd'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:158: in function <...faceRCLootCouncil\Classes\Services\Comms.lua:139>
[string "=[C]"]: ?
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@Ace3\AceComm-3.0\AceComm-3.0-12.lua"]:264: in function <Ace3\AceComm-3.0\AceComm-3.0.lua:246>

after /rc open during test session - empty window:

1x RCLootCouncil\Modules\votingFrame.lua:1369: attempt to index field '?' (a nil value)
[string "@RCLootCouncil\Modules\votingFrame.lua"]:1369: in function <RCLootCouncil\Modules\votingFrame.lua:1365>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `sort'
[string "@GuildSearch\Libs\lib-st\Core.lua"]:330: in function `SortData'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:561: in function `Update'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:670: in function `SwitchSession'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:195: in function `Show'
[string "@RCLootCouncil\core.lua"]:415: in function `?'
[string "@Ace3\AceConsole-3.0\AceConsole-3.0-7.lua"]:94: in function `?'
[string "@FrameXML\ChatFrame.lua"]:5073: in function <FrameXML\ChatFrame.lua:5019>
[string "=[C]"]: in function `ChatEdit_ParseText'
[string "@FrameXML\ChatFrame.lua"]:4737: in function `ChatEdit_SendText'
[string "@FrameXML\ChatFrame.lua"]:4773: in function <FrameXML\ChatFrame.lua:4769>
[string "=[C]"]: in function `ChatEdit_OnEnterPressed'
[string "*:OnEnterPressed"]:1: in function <[string "*:OnEnterPressed"]:1>

Locals:
table = <table> {
 sorttable = <table> {
 }
 filtered = <table> {
 }
 SortData = <function> defined @GuildSearch\Libs\lib-st\Core.lua:310
 cols = <table> {
 }
 GetDefaultHighlightBlank = <function> defined @GuildSearch\Libs\lib-st\Core.lua:450
 EnableSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:484
 scrollframe = ScrollTable2ScrollFrame {
 }
 Hide = <function> defined @GuildSearch\Libs\lib-st\Core.lua:300
 offset = 0
 GetRow = <function> defined @GuildSearch\Libs\lib-st\Core.lua:599
 showing = true
 Show = <function> defined @GuildSearch\Libs\lib-st\Core.lua:290
 DefaultEvents = <table> {
 }
 SetWidth = <function> defined @GuildSearch\Libs\lib-st\Core.lua:43
 Filter = <function> defined @RCLootCouncil\Modules\votingFrame.lua:1331
 SetFilter = <function> defined @GuildSearch\Libs\lib-st\Core.lua:433
 SetData = <function> defined @GuildSearch\Libs\lib-st\Core.lua:589
 SetSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:500
 DoFilter = <function> defined @GuildSearch\Libs\lib-st\Core.lua:438
 ClearSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:492
 data = <table> {
 }
 GetCell = <function> defined @GuildSearch\Libs\lib-st\Core.lua:607
 fSelect = true
 rows = <table> {
 }
 SetHeight = <function> defined @GuildSearch\Libs\lib-st\Core.lua:38
 SetDisplayRows = <function> defined @GuildSearch\Libs\lib-st\Core.lua:122
 FireUserEvent = <function> defined @GuildSearch\Libs\lib-st\Core.lua:65
 GetDefaultHighlight = <function> defined @GuildSearch\Libs\lib-st\Core.lua:465
 rowHeight = 20
 displayRows = 15
 defaulthighlightblank = <table> {
 }
 defaulthighlight = <table> {
 }
 RegisterEvents = <function> defined @GuildSearch\Libs\lib-st\Core.lua:78
 head = ScrollTable2Head {
 }
 SetDefaultHighlightBlank = <function> defined @GuildSearch\Libs\lib-st\Core.lua:454
 Refresh = <function> defined @GuildSearch\Libs\lib-st\Core.lua:764
 IsRowVisible = <function> defined @GuildSearch\Libs\lib-st\Core.lua:624
 SetDisplayCols = <function> defined @GuildSearch\Libs\lib-st\Core.lua:203
 RowIsVisible = <function> defined @GuildSearch\Libs\lib-st\Core.lua:624
 SetDefaultHighlight = <function> defined @GuildSearch\Libs\lib-st\Core.lua:469
 events = <table> {
 }
 DoCellUpdate = <function> defined @GuildSearch\Libs\lib-st\Core.lua:518
 GetSelection = <function> defined @GuildSearch\Libs\lib-st\Core.lua:509
 frame = ScrollTable2 {
 }
 SetHighLightColor = <function> defined @GuildSearch\Libs\lib-st\Core.lua:57
 CompareSort = <function> defined @GuildSearch\Libs\lib-st\Core.lua:356
}
rowa = 3
rowb = 1
sortbycol = 5
column = <table> {
 comparesort = <function> defined @RCLootCouncil\Modules\votingFrame.lua:1365
 name = "Response"
 DoCellUpdate = <function> defined @RCLootCouncil\Modules\votingFrame.lua:1176
 sort = 1
 sortnext = 13
 colName = "response"
 width = 240
}
a = <table> {
 name = "Meshsan-Kazzak"
 cols = <table> {
 }
}
b = <table> {
 name = "Meshsan"
 cols = <table> {
 }
}
(*temporary) = 505
(*temporary) = <function> defined @RCLootCouncil\core.lua:2285
(*temporary) = <table> {
 defaults = <table> {
 }
 ModuleChatCmd = <function> defined @RCLootCouncil\core.lua:2024
 StartHandleLoot = <function> defined @RCLootCouncil\core.lua:1592
 modules = <table> {
 }
 CancelTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:147
 SecureHook = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:336
 OptionsTable = <function> defined @RCLootCouncil\Modules\options.lua:138
 Stop

people who are in council when test is started - if they get window (sometime it shows sometimes not) they see people as addon offline or not installed:

1x RCLootCouncil\Modules\votingFrame.lua:168: attempt to call method 'OnReconnectDataReceived' (a nil value)
[string "@RCLootCouncil\Modules\votingFrame.lua"]:168: in function `_onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Observer.lua"]:30: in function `onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Subjects\Subject.lua"]:57: in function `next'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:163: in function `FireCmd'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:158: in function <...faceRCLootCouncil\Classes\Services\Comms.lua:139>
[string "=[C]"]: ?
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@Ace3\AceComm-3.0\AceComm-3.0-12.lua"]:218: in function `OnReceiveMultipartLast'
[string "@Ace3\AceComm-3.0\AceComm-3.0-12.lua"]:256: in function <Ace3\AceComm-3.0\AceComm-3.0.lua:246>

when adding additional items to test session:

1x RCLootCouncil\Modules\votingFrame.lua:1079: bad argument #2 to 'format' (string expected, got nil)
[string "=[C]"]: in function `format'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:1079: in function `UpdateSessionButton'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:333: in function `SetupSession'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:540: in function `OnLootTableAdditionsReceived'
[string "@RCLootCouncil\Modules\votingFrame.lua"]:173: in function `_onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Observer.lua"]:30: in function `onNext'
[string "@RCLootCouncil\Classes\Lib\RxLua\Subjects\Subject.lua"]:57: in function `next'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:163: in function `FireCmd'
[string "@RCLootCouncil\Classes\Services\Comms.lua"]:158: in function <...faceRCLootCouncil\Classes\Services\Comms.lua:139>
[string "=[C]"]: ?
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@Ace3\AceComm-3.0\AceComm-3.0-12.lua"]:264: in function <Ace3\AceComm-3.0\AceComm-3.0.lua:246>

All of us are using version 3.0.0-Beta1 from CurseForge

evil-morfar commented 4 years ago

The 3rd error is indeed a mistake on my end. I can't replicate the others as of yet. I would like to have a look at your SV.

s3thus commented 4 years ago

here's mine: RCLootCouncil.zip

evil-morfar commented 4 years ago

I managed to track down a few more of the issues. Only the filter one remains elusive to me.

s3thus commented 4 years ago

I've downloaded branch head again and did some testing: old errors don't show anymore but now I've new thing: whenever you choose response to item or timer timeouts this error shows - if it was timeouts it just keeps popping lua errors until reload ui happens - and item frame with button responses is still visible

1364x RCLootCouncil\Modules\lootFrame.lua:178: attempt to call method 'GetItemTextWithCount' (a nil value)
[string "@RCLootCouncil\Modules\lootFrame.lua"]:178: in function `OnRoll'
[string "@RCLootCouncil\Modules\lootFrame.lua"]:336: in function <RCLootCouncil\Modules\lootFrame.lua:336>

Locals:
self = <table> {
 SetDefaultModuleLibraries = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:367
 Enable = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:294
 NewModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:235
 EnableModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:332
 modules = <table> {
 }
 CancelTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:147
 IterateEmbeds = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:442
 defaultModuleLibraries = <table> {
 }
 TimeLeft = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:172
 CHAT_MSG_SYSTEM = <function> defined @RCLootCouncil\Modules\lootFrame.lua:595
 ScheduleRepeatingTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:129
 CancelAllTimers = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:160
 SetDefaultModulePrototype = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:409
 Show = <function> defined @RCLootCouncil\Modules\lootFrame.lua:127
 name = "RCLootCouncil_RCLootFrame"
 frame = DefaultRCLootFrame {
 }
 IsEnabled = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
 orderedModules = <table> {
 }
 ScheduleTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:94
 DisableModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:350
 ResetTimers = <function> defined @RCLootCouncil\Modules\lootFrame.lua:205
 items = <table> {
 }
 baseName = "RCLootCouncil"
 OnRollTimeout = <function> defined @RCLootCouncil\Modules\lootFrame.lua:615
 RegisterMessage = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
 UnregisterMessage = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
 CheckDuplicates = <function> defined @RCLootCouncil\Modules\lootFrame.lua:55
 EntryManager = <table> {
 }
 GetFrame = <function> defined @RCLootCouncil\Modules\lootFrame.lua:211
 OnRoll = <function> defined @RCLootCouncil\Modules\lootFrame.lua:162
 Update = <function> defined @RCLootCouncil\Modules\lootFrame.lua:136
 IsModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:217
 OnDisable = <function> defined @RCLootCouncil\Modules\lootFrame.lua:115
 SetDefaultModuleState = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:387
 OnEnable = <function> defined @RCLootCouncil\Modules\lootFrame.lua:109
 Start = <function> defined @RCLootCouncil\Modules\lootFrame.lua:69
 SetEnabledState = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:424
 AddSingleItem = <function> defined @RCLootCouncil\Modules\lootFrame.lua:92
 enabledState = true
 ReRoll = <function> defined @RCLootCouncil\Modules\lootFrame.lua:104
 RegisterEvent = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
 UnregisterAllMessages = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
 SendMessage = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:59
 UnregisterAllEvents = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
 AddItem = <function> defined @RCLootCouncil\Modules\lootFrame.lua:32
 IterateModules = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:437
 defaultModuleState = true
 GetModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:210
 GetName = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:279
 moduleName = "RCLootFrame"
 UnregisterEvent = <function> defined @Ace3\CallbackHand

Ofc both of us had same version od RCLC from branch head.

evil-morfar commented 4 years ago

That only happens with Print Responses enabled - will fix soon.

s3thus commented 4 years ago

when you promote new version to curseforge, feel free to close this ticket; if we encounter other issues during testing and/or raid I'll create another bug report :)

Thanks for your hard work to keep this addon working 👍

evil-morfar commented 4 years ago

I take it as you're having no more issues then 👏 Will do, and thanks for your help!