search

evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

Frame level #206

Closed enajork closed 3 years ago

enajork commented 3 years ago

Modules/Frames should now properly obscure each other (especially their contents) depending on which one has focus.

I did not test this thoroughly but I believe this is the correct solution to the problem.

enajork commented 3 years ago

It would also be great to get this fix into the Classic version as well. I see that the Classic version uses 7968cf257ef6cf4619367a575e5251649dfcda63 and might not benefit from these changes immediately. Thank you.

enajork commented 3 years ago

Whoops closed by accident. Sorry for spam.

enajork commented 3 years ago

I tested the session, voting, and history frames on Retail and Classic. Everything looks good. Some other modules/frames may still need to be tested.

evil-morfar commented 3 years ago

I've been wanting to look into this for quite a while, so thanks a lot!

Classic is still based on the v2 design, which doesn't have the frame creation in the same place. Shouldn't be too hard to implement though, as I more or less copy/pasted the code straight into Widgets/Frame.lua.

enajork commented 3 years ago

I implemented the fix in v2 first then in v3. Just didn't want to bother creating a separate pull request for v2 (seemed more complicated). Figured you would copy pasta for the Classic version 😄

Thank you so much!