evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

Huge import/export no longer freezes the game #71

Closed SafeteeWoW closed 6 years ago

SafeteeWoW commented 6 years ago

What causes the lag?


Changelog

evil-morfar commented 6 years ago

I'm aware the editbox causes the lag - my other comment was about I didn't like adding a lot of code for little gain. One thing worth mentioning is the way lua handles strings: creating/changing a lot of them is generally a bad idea, and should be avoided when possible - hence the usage of table.concat.

While I don't really like the aesthetics of a single line, I do think it's very much worth including if it can remove the lag. Maybe it's worth only using the single line version for consistency?

SafeteeWoW commented 6 years ago

I like to have both versions. I like to have multiple line version to enable preview, whenever possible. I don't want to lose feature that already works fine for small exports. I also want to do large export, so I create single line version. Indeed, aesthetics of a single line is bad, but this is probably the only solution until Blizzard fixes multiline EditBox widget for large string.