search

evilcorpltd / aTox

Reasonable Tox client for Android
GNU General Public License v3.0
365 stars 56 forks source link

Switch from Jackson to plain JSONObjects for exporting message history #1179

Closed robinlinden closed 10 months ago

robinlinden commented 10 months ago

Exporting the message history using Jackson on Android 4.4 leads to the app crashing with a NoClassDefFoundError.

See: https://github.com/FasterXML/jackson-databind/issues/2807

I compared a before and after export using diff <(jq . jackson.json) <(jq . jsonobject.json) and this results in no change other than a locationSaved top-level field disappearing.

robinlinden commented 10 months ago

After this, it is very little work to change up the format if we want to e.g. not include the public key in every message entry (which we probably don't,) but this change is set up to alter the output as little as possible, including preserving the pretty-printing whitespace. :P