evildmp / Arkestra

Arkestra extends Django CMS to provide an intelligent semantic web publishing system for organisations and institutions.
http://arkestra-project.org
BSD 2-Clause "Simplified" License
139 stars 27 forks source link

Pytest integration #131

Closed bubenkoff closed 9 years ago

bubenkoff commented 9 years ago

Please don't merge yet - work in progress this PR is here for travis

evildmp commented 9 years ago

Hi, thanks! I look forward to working with you.

bubenkoff commented 9 years ago

ok now it's OK to review

bubenkoff commented 9 years ago

@evildmp any feedback?

evildmp commented 9 years ago

Hello @bubenkoff - I am away at the moment, but I am looking forward to reviewing on Monday evening. Thanks for this contribution!

evildmp commented 9 years ago

Thanks for this. All seems to be working with the built-in example site, and with a local version of a real live site (http://2015.djangocon.eu).

This is great. Where do we go next, or what should I do to build on this? I would love to chat to understand better some of what you have done.

bubenkoff commented 9 years ago

do you have more output from tox? may be also try -v

bubenkoff commented 9 years ago

please also try

tox --recreate -v
bubenkoff commented 9 years ago

my tox output:

___________________________________________________________________________ summary ___________________________________________________________________________
  py26: commands succeeded
  py27: commands succeeded
  congratulations :)
bubenkoff commented 9 years ago

I think the best is that you'll enable travis and coveralls for this repo prior to merging

evildmp commented 9 years ago

Complete error-related output is at https://gist.github.com/evildmp/a9b144cf399de05b09ed.

evildmp commented 9 years ago

Huge thanks @christianmlong and @bubenkoff - after DjangoCon Europe and other work I am finally able to spend some time again on this. Your help is greatly appreciated, sorry I was not able to give this any of my time during the project itself but I will be building on the contribution you have made. Thanks again.

bubenkoff commented 9 years ago

thanks, I'll have another PR fixing the tests

evildmp commented 9 years ago

Can you understand why https://travis-ci.org/bubenkoff/Arkestra/builds/60875675 (your branch) is OK but https://travis-ci.org/evildmp/Arkestra/builds/71169557 (my branch, with identical code) has errors?

I can't make sense of it.

bubenkoff commented 9 years ago

it's a flaky test, I thing what's missing is the predictable order of objects

evildmp commented 9 years ago

It has suddenly started working on Travis. https://travis-ci.org/evildmp/Arkestra/builds/71324901 Since then, the develop branch passes on Travis as expected. Odd.