search

evildvl / vue-ics

MIT License
18 stars 12 forks source link

UID Issue #3

Closed nimashoghi0 closed 4 years ago

nimashoghi0 commented 4 years ago

Hi Evildvl,

This is a great package, one slight bug I have noticed is that the UID is the same for all added events. I believe this should be unique unless I'm mistaken. It only imports the one event into my calendar systems unless I make this UID unique for every event.

Hopefully this is a quick fix.

Kind Regards,

nimashoghi0 commented 4 years ago

I'm generating a ICS file from a list of events inside a timetabling system. Looking at the ICS string generator (see below), the seconds always match because of this process. Adding a Millisecond doesn't help as it's too fast, so I guess we need to add a counter++ to the end of the UID string.

var UID = "".concat(now_date.getDay()).concat(now_date.getMonth()).concat(now_date.getFullYear(), "-").concat(now_date.getHours()).concat(now_date.getMinutes()).concat(now_date.getSeconds()).concat(now_date.getMilliseconds());

Please let me know if you can do this so I can re-download the package, rather than having to create a local version of the package with the fix.

Thanks again,

nimashoghi0 commented 4 years ago

Alright I did my first pull request, I have fixed the issue, waiting for your merge 👍