evilhero / mylar

An automated Comic Book downloader (cbr/cbz) for use with SABnzbd, NZBGet and torrents
GNU General Public License v3.0
976 stars 169 forks source link

blacklisted_publishers not workingas intended #2332

Closed Buttonskill closed 3 years ago

Buttonskill commented 5 years ago

I can't seem to remove specified publishers utilizing the hidden config.ini feature. For background, I'm running 3 instances of Mylar in containers to keep comic lists manageable. Aside from the general undesirables like Panini Comics, I'd like DC comics removed from Marvel instance, Marvel removed from DC, and so on.

Here's what my indie comics syntax looks like: blacklisted_publishers = Editorial Novaro, Panini Comics, Editrice Cenisio, Planeta DeAgostini, Vanderhout, Editora Brasil-America Limitada, Les Humanoïdes Associés, Catalan Communications, Panini, Ediciones Zinco, TwoMorrows Publishing, Urban Comics, Super Genius Comics, Les Humanoïdes Associés, Titan Comics, ECC Ediciones, Taschen, Ave Fenix Comics y Libros, Titan Magazines, Comix-Art, Atlantic BD, Editorial Televisa, Tangent Comics, Hjemmet, Grupo Editorial Vid, Norma Editorial, Play Press, Dino Comics, TM-Semic, Semic, Egmont, JuniorPress BV, Chick Publications, Interpresse, Ehapa Verlag, Editions Héritage, Sage - Sagédition, Ehapa Verlag, Novedades Editores, Editorial Bruguera, Atlantic Förlag, Novedades Editores, Editora Brasil-América Limitada, Se-Bladene, Williams Förlag, DC Comics, Marvel Comics, DC, Marvel, Clasics\/Williams

Yet they still appear when tested on Superman search: image

Environment (please complete the following information):

And thank you for all the sorting hours you've gifted back to me by creating Mylar.

barbequesauce commented 5 years ago

I’m wondering if the accents and umlauts are causing issues. Can you please start Mylar in debug mode and create a new pull list, then post the debug log file (not from the webpage) on completion?

Buttonskill commented 5 years ago

You got it.

mylar.log

evilhero commented 5 years ago

I think what he meant to say was have debug enabled, and then do a search for a series via the upper search bar. We need to see if it's referencing the blacklisted list properly or if it's not. I don't think the special characters would impact things, altho it would have to write it to the ini file as a utf-8 encoded object.

BRTPOB commented 5 years ago

Are you sure that's the full Mylar log? It seems kind of...scant. Shows no searching or anything that you were looking for, just restarting.

Buttonskill commented 5 years ago

Are you sure that's the full Mylar log? It seems kind of...scant. Shows no searching or anything that you were looking for, just restarting.

No, you're right. There was a folder check in there that I omitted with the intention of reducing time spent analyzing it. Just habit. When I share a log I tend to keep it succinct and focused on the repro.

I think what he meant to say was have debug enabled, and then do a search for a series via the upper search bar. We need to see if it's referencing the blacklisted list properly or if it's not. I don't think the special characters would impact things, altho it would have to write it to the ini file as a utf-8 encoded object.

I was wondering why the pull list was relevant there. Here's a restart search: mylar.log

But keep in mind that my config.ini for this search has been reduced to blacklisted_publishers = Panini Comics, DC Comics, Marvel Comics ..in an attempt to rule out the umlauts and such.

image

BRTPOB commented 5 years ago

OK, so I have to believe it's how you've got yours setup. I just added DC Comics to my blacklist, thus it looks like this: blacklisted_publishers = Panini Comics, DK Publishing, ECC Ediciones, Planeta DeAgostini, Dino Comics, RW Uitgeverij, Grupo Editorial Vid, Editorial Televisa, ID Komiks, DC Comics

This is what my search results look like:

image

evilhero commented 5 years ago

Are you using a seperate config.ini for each docker? Are you restarting mylar after each manual config.ini change (you shouldn't be editing it at all when it's running)? Does the blacklisted_publishers appear under the [CV] section of the ini?

Buttonskill commented 5 years ago

Are you using a seperate config.ini for each docker? Are you restarting mylar after each manual config.ini change (you shouldn't be editing it at all when it's running)?

That's correct. Separate config.ini's for each container. General path I stick to:

  1. Copy config.ini to another directory
  2. edit in notepad++ or nano
  3. stop the container
  4. copy and overwrite /mylar/config.ini
  5. Start container

Does the blacklisted_publishers appear under the [CV] section of the ini?

It's under [CV] section too

[CV] cv_verify = True cv_only = True cvinfo = True blacklisted_publishers = Panini Comics, DC Comics, Marvel Comics

BRTPOB commented 5 years ago

Question: why aren't you just killing Mylar instead of adding in the additional steps of copying to/from?

Buttonskill commented 5 years ago

Question: why aren't you just killing Mylar instead of adding in the additional steps of copying to/from?

Ease of editing? More personal preference editing in notepad++ I suppose. Log can be open in one tab, config.ini in another, etc.

evilhero commented 5 years ago

Just realized, the commit you're running doesn't seem to be current - 38aksi1 and I can't find a reference to it thus far. Can you confirm your actual commit that you're using by taking the first 7 characters from the bottom of any mylar page (or from the 1st tab in the configuration, which also shows where your ini is being loaded from as well)

Buttonskill commented 5 years ago

Absolutely:

68a8e77

My docker compose pulls: image: "linuxserver/mylar:amd64-latest"

Which I was hoping would put me on the development branch, but it doesn't look like that's supported. Merely pulls the latest master from the looks of it.

evilhero commented 5 years ago

Yep docker will always lock you on master as they believe development is too unstable (they generalize for every repo, however Mylar's dev branch is probably more stable due to the frequent commits normally). However, due to the last development merge into master, you're almost current with development regardless.

I'll have to code dive this when I get a chance. My free time is non existant until the kidlets go back to school in a few weeks - but after that I'll be committing fixes/enhancements like a demon to make up for the past 2 months of my self-imposed exile / "vacation."

Buttonskill commented 5 years ago

No worries at all. Hell, prioritize the real issues when you get back at it. Nothing is truly broken here, and I can respect that this issue can be considered pedantic by comparison.

This is really somewhat of an entrypoint for me to hopefully contribute. I've messed around in other instances and made attempts to support python 3 with comicRN.py (Not this one. The instance in question here is clean), but mostly been lurking for a year and found all my answers in your other responses.. And there's a lot of responses.