evilhero / mylar

An automated Comic Book downloader (cbr/cbz) for use with SABnzbd, NZBGet and torrents
GNU General Public License v3.0
976 stars 172 forks source link

New ComicVine API #306

Closed evilhero closed 11 years ago

evilhero commented 11 years ago

Just a headsup for everyone in the latest developmental build, you now have the option to go away from the use of the 'custom_exeptions' and some of the problems experienced.

To enable the CV option, in your config.ini put in: cv_only = 1

A refresh on each comic is required in order to pull in the new data - you'll know it's pulled in because the issue #'s have no more decimal places. Keep in mind that if doing a refresh, there's a very good chance you'll encounter an error (like pipieye did in the post just below) because it already has the issue data present and it doesn't match up. In this case, you'll have to delete the series, then do a readd and it will come down ok (this only has to be done initially to make the switch to the CV). I'll be trying to post up an option or two that will enable the refresh to happen without having to delete the series first.

If you want to do your entire db at once, in the config.ini put in: cv_onetimer = 1

Then go to the Force Rescan on the Manage tab and let it work through. If there are any problems, please let me know. It's supposed to maintain your wanted/skipped lists as well for each series as it goes through. Once the process has completed, it sets the onetimer to 0 so it won't run again on another db update process.

As a side note, you can combine both processes as well (new use of CV, and the previous use of CV/GCD). Simply enable the cv_only option (=1). Any series' that are in your watchlist that are being pulled from GCD (ie. multi-volumes would be the main offenders), will retain the info and still update as per normal.

This is all in an attempt to ease alot of frustration with the use of 2 db's and to get it down to one.The GCD option will still be available/maintained going forward, but may see some other uses (optional selections when adding, etc).

pipieye commented 11 years ago

06-Apr-2013 07:54:15 - INFO :: Thread-15 : Sucessfully retrieved details for The Phantom Stranger 06-Apr-2013 07:54:15 - INFO :: Thread-15 : Directory (/Volumes/sg3tb2/Comics/0day/DC Comics/The Phantom Stranger (2012)) already exists! Continuing... 06-Apr-2013 07:54:16 - INFO :: Thread-15 : Sucessfully retrieved cover for The Phantom Stranger i:91 06-Apr-2013 07:54:17 - DEBUG :: Thread-15 : issues I've counted: 8 06-Apr-2013 07:54:17 - DEBUG :: Thread-15 : issues CV says it has: 8 Exception in thread Thread-15: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 552, in bootstrap_inner self.run() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 505, in run self.__target(_self.args, *_self.__kwargs) File "/Users/csotto/Myapps/Mylar/mylar/mylar/importer.py", line 290, in addComictoDB issued = cv.getComic(comicid,'issue') File "/Users/csotto/Myapps/Mylar/mylar/mylar/cv.py", line 76, in getComic if type == 'issue': return GetIssuesInfo(comicid,dom) File "/Users/csotto/Myapps/Mylar/mylar/mylar/cv.py", line 190, in GetIssuesInfo issue['Issue_Number'] = dom.getElementsByTagName('issue_number')[n].firstChild.wholeText AttributeError: 'NoneType' object has no attribute 'wholeText'

evilhero commented 11 years ago

try restarting Mylar and readding it - I was just able to add that particular series without any issues but it wasn't updating the series (it was adding a new series).

If by chance you've enabled the CV_ONLY option and just did a refresh (without doing the manual db onetimer), you'll have to delete the series and readd it.I've been trying to get it to do it on a refresh but haven't had much luck at all as of yet. Basically all of the issues tagged to a given series (in the issues table), needs to get deleted - then a fresh add because there are duplicate issue #'s

pipieye commented 11 years ago

sorry, forgot to mention config.ini was not touched, when I looked, cvinfo = 0. There is no CV_ONLY entry in there. Also when I tried the delete and add series, I get the following

06-Apr-2013 08:03:38 - DEBUG :: Thread-16 : you have a total of 6 The Phantom Stranger comics 06-Apr-2013 08:03:38 - DEBUG :: Thread-16 : temploc: 000 (2012) (2 covers) (digital-TheGroup).cbr Exception in thread Thread-16: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 552, in bootstrap_inner self.run() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 505, in run self.__target(_self.args, *_self.__kwargs) File "/Users/csotto/Myapps/Mylar/mylar/mylar/updater.py", line 493, in forceRescan if old_status == "Skipped": UnboundLocalError: local variable 'old_status' referenced before assignment

evilhero commented 11 years ago

Yeah, the cv_only option gets added on a config write - either by way of Save Settings, or when you shutdown Mylar. You can also just add it in yourself, and Mylar will use the value given then (0 = off, 1 = on)

That being said, you're getting an error totally outside of that from the looks of it. I'll look into it now and see what's going on.

TheLabRatt commented 11 years ago

Great work - at last I can add "Mask of the Red Panda" which, being digital only, was never going to be indexed at comics.org.

DGMayor commented 11 years ago

You might want to put in a check so when you refresh a comic, if you have the cvinfo option checked, it re-writes it. With the changes to Comicvine, some of my cvinfo files are now incorrect, and they're not rebuilding unless I manually delete them.

evilhero commented 11 years ago

DGMayor: done in latest commit - just make sure to have cv_only and cv_onetimer enabled.