search

evilhero / mylar

An automated Comic Book downloader (cbr/cbz) for use with SABnzbd, NZBGet and torrents
GNU General Public License v3.0
976 stars 172 forks source link

KAT search not picking up files due to leading zero #540

Closed quesog closed 7 years ago

quesog commented 11 years ago

This appears to be a limitation on the search API of kat.ph, but a search for "Superhero Comic 23.3" doesn't return any results because all results are named "Superhero Comic 023.3".

evilhero commented 11 years ago

I think it may be an issue with the decimal place in the issue# more so than the leading zero, but that's just my thinking due to some similar issues earlier in the week. I'll check into it tonight or early tomorrow and see what's going on.

quesog commented 11 years ago

Hey, thanks for replying back so quickly. The only reason I thought it would be the leading zero is that:

http://kickass.to/usearch/Green%20Lantern%2023.3%20category:comics%20seeds:1/?rss=1

returns nothing, while

http://kickass.to/usearch/Green%20Lantern%20023.3%20category:comics%20seeds:1/?rss=1

finds results.

evilhero commented 11 years ago

Hmm well if that's the case then that's definitely the problem. It should be cycling through all iterations of an issue number (23, 023 or 001, 01, 1) as it does with nzbs - it may be even something simple as a lack of an iteration loop, but either way that's definitely fixable so that Mylar can pass the correct info to KAT.

evilhero commented 11 years ago

Ok, so I checked the code - it does already loop the various iterations of an issue regardless of the provider used (torrents/usenet)....so it searches through 023.2 / 23.2 ..

However, I know why you're not getting any results - at least in the case you provided. The Green Lantern in question is posted with the volume #, which if it's given Mylar uses that as an indication of a successful match or not.

Here's the catch - when a series is added/refreshed, Mylar checks to see if a volume # is provided in the Edit Settings for a given comic. If there is, it doesn't do anything and uses that. If there isn't, it attempts to poll the volume information from ComicVine. In most cases, the volume is given in the proper format of V# or Volume #, but in the case of Green Lantern, it\s given as 'Fifth Volume' which Mylar doesn't consider a valid format for Volume information.

So basically, on the Edit Settings tab of the comic, under Version Number - put in 'v5' without the quotes. Update the settings, and then try again - you should get the hit you want.

All these villains-month issues are a pita - because they have information after the issue # (like Darkseid, or Dial E, etc), it throws off Mylar's algortihims for determining a correct match so it won't download them. I'm working on a fix, but if I push it out, it will break everything else :(

quesog commented 11 years ago

Thanks for looking in to it. Adding the v5 definitely fixed GL.

At least Villains Month will be over soon, and things will go back to normal.