evilhero / mylar

An automated Comic Book downloader (cbr/cbz) for use with SABnzbd, NZBGet and torrents
GNU General Public License v3.0
976 stars 169 forks source link

Bug with Annuals option in .ini #771

Closed Aquenon closed 9 years ago

Aquenon commented 10 years ago

I enabled the annuals option in the .ini file as you told me to last night. I noticed that a new series I added (Silver Surfer) showed the annuals at the bottom of the page and it had a 'Delete Annuals' button at the top.

However, on a series I had added prior to enabling the annuals option (The New Mutants) did not have either of those things, even though it has 7 annuals. I deleted The New Mutants and re-added it which did not change anything. So, either its an issue with that series which is out of your control, or an issue with the fact that I added the series before I enabled the option. I tried to log in the DB file, but that was confusing. Thanks for all your work!

evilhero commented 10 years ago

Well the auto-adding of annuals is based purely on the description field that ComicVine has for the actual series. It's not perfect, but it's the best that can be done given the circumstances thus far. I just checked on CV, it's due to the fact that they don't actually name the series that the annuals belong to.

Best way to get them added is to use the ComicID button at the very bottom right for the series on the comic details screen.

annual_add

Enter in the ComicID for the annual series (in this case : 4050-3356) and then click the green arrow icon beside the text field. It will then proceed to add them in accordingly (you'll have to refresh the screen after you click on the green arrow button to add the series).

Aquenon commented 10 years ago

oh, that's awesome. I didn't know that's what that field was for. I'll try that tonight. Thanks for getting back to me so fast! I have another question. I have three series that will not finish loading. "TSR Worlds (1990)" and "Voltron (1985)". It pulls in most of the information except for the dates on the individual issues and it keeps trying to load the info. I figure I'd have to enter the information directly into the .db file, but I don't know how to do it without corrupting the entire thing (and at this point, I would cry if that happened...lol). Again, thank you very much for your quick support and for writing this software!!!

Scott

evilhero commented 10 years ago

Technically another issue, but the TSR Worlds and Voltron both don't get added due to the fact that there is no issue dates available for all of the issues:

You can see the Publication Date is kinda messed up: voltron

And the issue data is all listed as 0000-00-00: voltron2

I patched this awhile ago on my local repo (and just tested adding those series in), and both came in just fine so this will be available and ready in the upcoming development commit. Until then, you probably won't be successful in trying to add these series into your watchlist.

As an added bonus, I've also added in a date editor now, so that if dates are coming in as 0000-00-00 or are completely wrong, you can edit the date to the correct value and things don't get broken in regards to refreshing, searching, filechecking, etc.

With the bad issue data: voltron3

Corrected and ready to go searching: voltron4

Aquenon commented 10 years ago

Data editor? This just keeps getting better and better =)