evilkost / brukva

Asynchronous Redis client that works within Tornado IO loop.
Other
265 stars 33 forks source link

Extract adisp and upload it to pypi #11

Open kmike opened 13 years ago

kmike commented 13 years ago

What do you think about extracting tornado-specific adisp library from brukva and releasing it under e.g. 'adisp-tornado' name?

drdaeman commented 13 years ago

As a reverse opinion, maybe swirl should be taken into consideration, too?

It does (almost) the same thing, just with a bit different syntax, and I got the impression that it's the most preferred async sugar in Tornado community. Swirl lacks @async, though, using lambdas to achieve the same effect, which is a regrettable.

kmike commented 13 years ago

Yes, switching to swirl is an another option.

Adisp though is also well-known (at least in Russian python community) and proven library (it appears a couple of week earlier than swirl) with nice API and implementation so this is not a variation of NIH sindrome ;) Adisp is available at launchpad : https://launchpad.net/adisp but the version there does not include evilkost's tornado fixes and it is not uploaded to pypi.

All these reasons are community-related. Adisp community is just not as visible as swirl's (because of launchpad vs github, Russian blog post vs English blog post) but this community exists for sure. I don't think swirl should be considered 'standard solution' while adisp being an incarnation of NIH sindrome, they are both used by many people.

Besides the community there are technical reasons. The lack of 'async' decorator is not a serious issue because it can be implemented in a couple of lines. I don't have an experience with swirl and my experience with adisp is quite limited (while being positive) so technical advantages are not clear for me and this need some investigation. Both libraries work.

So I don't have neither community nor technical arguments for adisp vs swirl question :) It is easier to extract adisp than to convert brukva to swirl and so without better arguments it seems preferrable to extract adisp.