search

evilmartians / figma-polychrom

Figma plugin for displaying the contrast level and font size recommendations according to the APCA method
https://www.figma.com/community/plugin/1281280685402026529/polychrom
MIT License
67 stars 5 forks source link

Don’t inline fonts/images manually #7

Open ai opened 1 year ago

ai commented 1 year ago

Right now we manually put font in data:uri format https://github.com/mikhin/vite-figma/blob/main/src/ui/style.css#L15

But it is not really maintainable. You can’t open font/image file in system viewer. You can’t replace font just by replacing the file.

Vite can’t inline font by it own. We should keep fonts/images as a regular files and inline them by built tools.

Also, inline is a little bad practice. Font files are big. And base64 decoding and CSS parser is not free. Maybe we should move to separated file and preload tag in HTML.