evilmartians / fullstaq-ruby-docker

Docker image for Ruby build from Fullstaq packages based on Debian 10, 11, and 12.
https://evilmartians.com/chronicles/fullstaq-ruby-first-impressions-and-how-to-migrate-your-docker-kubernetes-ruby-apps-today
174 stars 21 forks source link

Fix ruby not found after load /etc/profile #25

Closed OuYangJinTing closed 1 year ago

OuYangJinTing commented 1 year ago

Motivation / Background

I used whenever in code. The task prefix in the crontab file generated by whenever is bash -l -c {XXX}, which loads the /etc/profile file and changes PATH, resulting in a "command not found" error.

Changed

Writing the PATH setting into /etc/profile is to avoid the problem of command not found due to PATH changes.

PS: English is not my native language; please excuse typing errors.

OuYangJinTing commented 1 year ago

Some jobs failed due to network, but I cannot control rerun job. Can you help me with it?

Envek commented 1 year ago

Don't mind failing builds: Debian 9 isn't supported anymore and builds for it stopped to work as there are no packages for it. I removed these builds in main branch. No action required in this pull request.

Envek commented 1 year ago

Thank you very much for your contribution!

Updated images are already on the Quay. Please enjoy your fix.