evilmartians / oklch-picker

Color Picker for LCH
https://oklch.com
Other
849 stars 65 forks source link

Update range #112

Closed ghost closed 1 year ago

ghost commented 1 year ago

What's new?

In the mixin of the range component, it is written that you need to show the div.range_gradient if type is alpha. Only you can simplify everything. Each range class has an .is-{type}. Plus, .is-a already had styles. I removed the div.range_gradient element and just add a pseudo-element exclusively from .is-a. After I changed the logic of the mixin and make a canvas render when type !== alpha. I think it's easier and more logical

ghost commented 1 year ago

I have corrected. Look, did I understand you correctly?

ai commented 1 year ago

Here is how I fixed it (2 properties is too short to share them) ff70363

ghost commented 1 year ago

Okay. Thank you!