chrome support - Githubissues

evilpie / 404-bookmarks

Firefox extension to find and remove expired bookmarks.

https://addons.mozilla.org/en-US/firefox/addon/404-bookmarks/

Mozilla Public License 2.0

17 stars 4 forks source link

chrome support #15

Closed nekolr closed 4 years ago

nekolr commented 4 years ago

Thanks to the author for developing this extension. I made a few modifications based on this repo to support the chrome browser.

see: https://github.com/nekolr/404-bookmarks

evilpie commented 4 years ago

Thanks for reaching out. If you want I could merge some of those changes like s/browser/chrome/

nekolr commented 4 years ago

Thanks for reaching out. If you want I could merge some of those changes like s/browser/chrome/

My pleasure, what should I do, the changes I made on the chrome branch

evilpie commented 4 years ago

Sure.

I mean these changes where you use "chrome.xyz" instead of "browser.xyz": https://github.com/nekolr/404-bookmarks/commit/29aa41f1993ae6c7794954adf39eb3efa212abcb#diff-f9b12bd72f40c9b8ed144484f0f12a5fL5
I see you added some Chinese comments in certain undocumented places, translated to English adding those would probably be a good idea as well.
I think we still need https://github.com/nekolr/404-bookmarks/commit/29aa41f1993ae6c7794954adf39eb3efa212abcb#diff-9a9569e9d73f33740eada95275da7f30L5-L26 otherwise you get a lot of wrong results in Firefox.

So if you want you can open a PR with just those first two items, otherwise feel free to just ignore this. I am not actively working on this extension at the moment anyway.

nekolr commented 4 years ago

Sure.

* I mean these changes where you use "chrome.xyz" instead of "browser.xyz": [nekolr@29aa41f#diff-f9b12bd72f40c9b8ed144484f0f12a5fL5](https://github.com/nekolr/404-bookmarks/commit/29aa41f1993ae6c7794954adf39eb3efa212abcb#diff-f9b12bd72f40c9b8ed144484f0f12a5fL5)

* I see you added some Chinese comments in certain undocumented places, translated to English adding those would probably be a good idea as well.

* I think we still need [nekolr@29aa41f#diff-9a9569e9d73f33740eada95275da7f30L5-L26](https://github.com/nekolr/404-bookmarks/commit/29aa41f1993ae6c7794954adf39eb3efa212abcb#diff-9a9569e9d73f33740eada95275da7f30L5-L26) otherwise you get a lot of wrong results in Firefox.

So if you want you can open a PR with just those first two items, otherwise feel free to just ignore this. I am not actively working on this extension at the moment anyway.

I mean maybe we can open another branch and then I submit a pr to this branch? yeah, i will clear chinese comments.

evilpie commented 4 years ago

Sounds about right. Create a new branch in your fork with just those changes and then open a pull request.

nekolr commented 4 years ago

Maybe you can create a new branch, and i will submit a pr to that branch?