search

evilpie / add-custom-search-engine

Add a custom search engine to the list of available search engines in Firefox
https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/
Mozilla Public License 2.0
173 stars 13 forks source link

Add keyboard shortcut option with Ctrl+Shift+F as default #13

Closed mk-fg closed 4 years ago

mk-fg commented 4 years ago

Only a minor change to manifest.json to allow removing UI button in favor of keyboard shortcut. Idea is to avoid cluttering UI for relatively rare action, yet not require going through Ctrl+Shift+A and extra clicks there.

Picked Ctrl+Shift+F as default, as it's easy to keep in mind next to Ctrl+F (regular page search), can be changed or disabled by user in about:addons. Might be worth mentioning the key in AMO addon description, either as a feature or to avoid surprising anyone.

Thanks!

evilpie commented 4 years ago

Thank you for your contribution. This seems like a pretty nice shortcut combination to "waste" on this extension. Realistically how often do you add new search engines to make this worthwhile?

mk-fg commented 4 years ago

Well, if it's not used otherwise, it's no waste. And if it is, pretty sure firefox just won't assign it, and if someone wants to use it for something else, they can un-assign or reassign it too. But I only have like 5 extensions installed, so don't know whether spare keys are rare commodity and should be treasured :)

Probably don't add search engines a lot either.

evilpie commented 4 years ago

Sounds good

evilpie commented 4 years ago

Depending on how much work it turns out to be I want to look into localization before releasing a new version. Thanks!

mk-fg commented 4 years ago

Depending on how much work it turns out to be I want to look into localization before releasing a new version.

No worries, use waterfox here, so had addon with the change before PR. Thanks for making and maintaining it.