evilpie / add-custom-search-engine

Add a custom search engine to the list of available search engines in Firefox
https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/
Mozilla Public License 2.0
177 stars 15 forks source link

connection to file.io #2

Closed atomGit closed 6 years ago

atomGit commented 6 years ago

apparently this add-on uses file.io to create the plugin even when a description is not added, though this is not stated in the AMO description

just curious why it needs to use an external resource at all

thanks

atomGit commented 6 years ago

never mind - i believe i found the answer to my question in the Search Engines Helper GitHub page

evilpie commented 6 years ago

I think I made it pretty clear that this uses file.io, for technical reasons. Is it not obvious enough?

atomGit commented 6 years ago

from the privacy policy on AMO...

Due to a technical limitation in Firefox your search engine description is temporarily uploaded to file.io.

this leads one to believe that a connection to file.io is not made unless one provides a description

evilpie commented 6 years ago

Oh, I see. This comes from "OpenSearch description formation". I might think of some better term.

atomGit commented 6 years ago

i might suggest simply changing it to...

Due to a technical limitation with Firefox WebExtensions, this add-on uses a 3rd party service provided by file.io to configure your custom search engine plugins. file.io stores this data temporarily. You can read their privacy policy and terms of service here: https://www.file.io/

atomGit commented 6 years ago

oh, also wanted to ask why the connection to file.io is not in the add-on permissions? i'm just curious and this question is not really specific to your extension - i'm just wondering if you might know why this may be

even when i use the Project Insight extension, it doesn't list the file.io URL

evilpie commented 6 years ago

Thanks, I think that is good description.

oh, also wanted to ask why the connection to file.io is not in the add-on permissions?

file.io uses CORS, so any website (including a webextension page) could upload data to it.