search

evilpie / add-custom-search-engine

Add a custom search engine to the list of available search engines in Firefox
https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/
Mozilla Public License 2.0
173 stars 13 forks source link

Update search.html #27

Closed d-a10 closed 3 years ago

d-a10 commented 3 years ago

It doesn't necessarily have to say this but the way it's currently written suggests you're introducing something new when you're really just finishing the process. I was confused by this and thought the plugin had lost functionality and found others online with the same issue.

Alternately it could say "1 more step! Adding the new search engine via the URL bar"

evilpie commented 3 years ago

Thanks for the pull request. I didn't realize that this message could confusing. And sorry for not responding sooner, I don't check github notifications regularly.

I think

Lastly, add the new search engine via the URL bar

as a big text is maybe a bit ugly.

Maybe we could do something like:

Almost done just two more steps

  1. Open the "Page actions" menu
  2. Click "Add Search Engine"
d-a10 commented 3 years ago

No worries, I only just now realized you left a message. Sounds good, I went ahead and changed it.