search

evilpie / add-custom-search-engine

Add a custom search engine to the list of available search engines in Firefox
https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/
Mozilla Public License 2.0
173 stars 13 forks source link

Search through drag-and-drop onto a new tab stopped working for some engines #30

Closed github-account1111 closed 3 years ago

github-account1111 commented 3 years ago

Dragging highlighted text onto the space between tabs or the end of the tab bar used to open a new tab and search for it using the default search engine - in my case, Startpage. Since updating FF to 83, performing the aforementioned action has just been opening the Startpage homepage.

To see if this is an issue on Startpage's end I added Duckduckgo and assigned it default, and it exhibited the same issue.

Interestingly, this does not seem to happen with Qwant or Google.

Note: dragging highlighted text onto a tab works properly with all engines and performs a search for the text in that tab. Regular searching through the address bar also works.

evilpie commented 3 years ago

This sounds like a Firefox issue.

github-account1111 commented 3 years ago

Does merely sounding like a Firefox issue warrant closing it? Have you at least tried reproducing?

If anything, the fact that only certain engines exhibit this behavior makes it sound like a non-FF issue to me.

Even if it were a Firefox issue, wouldn't you wanna work around it so the extension works properly with FF?

evilpie commented 3 years ago

Can you search normally with these engines? i.e using the search bar or explicitly selecting them in the URL bar? I can't reproduce this problem when installing the engine provided by startpage.com.

It's still extremely unlikely this is a problem with my extension and we can't workaround issues like this anyway.