search

evilpie / add-custom-search-engine

Add a custom search engine to the list of available search engines in Firefox
https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/
Mozilla Public License 2.0
173 stars 13 forks source link

Firefox Proton removes all page actions including "Add search engine" #33

Closed Redfire75369 closed 3 years ago

Redfire75369 commented 3 years ago

Following the steps on the add search engine page, I am unable to add the search engine as there is no "Add Search Engine" option.

Environment: Windows 10 10.0.18363 Build 18363 Firefox Developer Edition 88.0b6

evilpie commented 3 years ago

Still works for me in Nightly. Can you tell me the settings you used?

Redfire75369 commented 3 years ago

I did some testing because I had a slight suspicion it was caused by the Proton redesign. The option browser.proton.urlbar.enabled=true resulted in the "Add Search Engine" option disappearing.

allanlaal commented 3 years ago

the Page Actions menu has been removed from the URLbar/awesomebar since Firefox ≥ 89.0b3 (Proton UI :vomiting_face: )

setting [browser.proton.enabled = false](about:config) disabled the UI "improvements", but did not bring that menu back (and also hid its new location)

in the new Puketon.. I mean Proton: one has to Right Click on the urlbar and the Add Search Engine option appears there on first load.. sometimes

allanlaal commented 3 years ago

@Redfire75369 @evilpie could you edit this issue title to FIX "Add Search Engine" and its "Page Actions"/.../meatball menu missing in Firefox Proton (≥v89)

evilpie commented 3 years ago

Thanks for reminding me. Having to right click is somewhat annoying to visualize :(

titaniumbones commented 3 years ago

Hi, I'm running firefox nightly too and I do not see a way to actually add the new search engine. I tried setting browser.proton.enabled to false but as indicated above that did not seem to bring back the menu item. The right-click context menu also doesn't show the option. Am I missing this/reading it wrong?

evilpie commented 3 years ago

Right clicking the address bar didn't work? It's working for me with proton enabled.

titaniumbones commented 3 years ago

proton is enabled and the ight click menu looks as followed when clicked from (a) the extension "create new engine" page, and (b) a normal page, in this case on researchgate. research-gate-page-r-click extension-page-r-clickmenu

thanks for the quick response!

evilpie commented 3 years ago

Weird, do you see anything in the browser console? (Ctrl+Shift+J)

leijurv commented 3 years ago

This UI change appears to have been rolled out globally or something. I just got it and I'm not on any beta (that I know of).

I believe the issue is that adding the link element in JavaScript is no longer sufficient.

I performed the above test with researchgate, and I saw the same behavior. Add "ResearchGate search" appeared on that page, but nothing appeared on your extension.

I copied the two link elements into a local .html file. If I put in <link rel="search" type="application/opensearchdescription+xml" title="r" href="https://paste.mozilla.org/9EiMJrKP/raw"> (copied from the inspect element view), it worked fine and showed up. Same for <link rel="search" type="application/opensearchdescription+xml" title="ResearchGate search" href="https://www.researchgate.net/application.DownloadOpenSearchPlugin.html">.

I suspect/fear that Firefox changed something up internally, and now <link rel="search" only works if it is in the HTML on initial page load, and it won't show up if it's added later using JavaScript.

evilpie commented 3 years ago

Still works fine for me, just have to right click. I am going to update the help text and screenshots tomorrow or so.

evilpie commented 3 years ago

If you can reproduce this reliably it would be useful if you could take a look at the browser console (Ctrl+Shift+J)

evilpie commented 3 years ago

Released version 4.1: https://addons.mozilla.org/firefox/addon/add-custom-search-engine/ (https://github.com/evilpie/add-custom-search-engine/commit/8210107bb72cb1be0462ecf5bfe519ddc602f00e)

leijurv commented 3 years ago

Huh... I can't reproduce this anymore. I might have just been doing something wrong earlier today. Or some cache issue. Or your update.

Regardless, all seems well now, no issue anymore (at least for me) :) 👍

codepincher commented 9 months ago

I am still having this issue...I've found the https://paste.mozilla.org link but have no idea how to add it. Nor do I know how to add the functionality for the custom search back to firefox.

I added the website's plugin but I'd prefer not to have to do so for every website, and of course there are websites that don't have one.