search

evilpie / add-custom-search-engine

Add a custom search engine to the list of available search engines in Firefox
https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/
Mozilla Public License 2.0
173 stars 13 forks source link

Allow use of a custom dpaste server URL #37

Open superjamie opened 3 years ago

superjamie commented 3 years ago

As you have said, the WebExtensions API requires an external intermediary to "publish" the OpenSearch engine and you are currently using the Mozilla Pastebin https://paste.mozilla.org/ for this.

The Mozilla Pastebin is just an instance of dpaste, an open source Pastebin.

I assume the extension could theoretically use any dpaste sever, and is not bound to only use Firefox Pastebin.

If so, users could host their own dpaste server (even temporarily, like a throwaway container) to allow publishing of OpenSearch engines where the user has control of their data and is not exposing their data publicly on the Mozilla Pastebin.

Is it possible for this extension to allow a custom dpaste URL?

TFWol commented 3 years ago

I was thinking the same thing. @evilpie Could this post have the Enhancement label?

For the Addon: Maybe have an option to fill in a custom URL? The default URL could be prefilled pointing to https://paste.mozilla.org/

@superjamie I'm not too familiar with JavaScript, but I'm thinking a section in the manifest would need to be modified https://github.com/evilpie/add-custom-search-engine/blob/55cd8450f2db28366992b40a62164e7055bdf263/manifest.json#L37-L40

Doing so would probably require wildcards and cause the Store extension permissions changing from:

This add-on needs to: Access your data for paste.mozilla.org

to:

This add-on needs to: Access your data for all websites

Generally add-ons that say that make me squeamish if I can't see the source code. Having the Recommended label would probably help in that case.

ericrbg commented 3 years ago

This would also be nice, as as far as I can tell the current solution is broke; it's set to one-time and something in FF is reading it before it can get added to my search.

E: God this is so frustrating. I don't know why Mozilla decided that they can't make a convenient way to do this...

Edit2: never mind, I think the "suggest URL" option is borked.