search

evilpie / add-custom-search-engine

Add a custom search engine to the list of available search engines in Firefox
https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/
Mozilla Public License 2.0
173 stars 13 forks source link

getting Name and Icon by Search URL doesn't work #7

Open 532910 opened 5 years ago

532910 commented 5 years ago

https://github.com/soufianesakhi/firefox-search-engines-helper Entering https://search.f-droid.org/?q=%s into Search URL will fill Name with search.f-droid.org and Icon with https://www.google.com/s2/favicons?domain=search.f-droid.org

Add custom search engine will not set Name with "Please fill out this name" error. Will fill wrong Icon URL: https://search.f-droid.org/favicon.ico

evilpie commented 5 years ago

https://github.com/soufianesakhi/firefox-search-engines-helper Entering https://search.f-droid.org/?q=%s into Search URL will fill Name with search.f-droid.org and Icon with https://www.google.com/s2/favicons?domain=search.f-droid.org

Add custom search engine will not set Name with "Please fill out this name" error.

I am not convinced yet that auto-filling the name is useful enough.

Will fill wrong Icon URL: https://search.f-droid.org/favicon.ico

Yeah, that kind of sucks. I don't have a good idea on how to fix this without using the Google service like "Search engine helper", or actually fetching the search URL. Auto-filling the icon is more of a best effort kind of thing. I am almost tempted to remove it, but it does work for a lot of websites.