search

evilrat666 / directx-d

[DISCONTINUED] DirectX bindings for D
MIT License
20 stars 16 forks source link

Is PR Open for adding versionings? #13

Open MrcSnm opened 1 year ago

MrcSnm commented 1 year ago

For not building everything, I'm going to add:

version(Direct2D_1)
version(Direct2D_1_1)

And friends. As I'm only using a subset of directx, I believe this makes sense for me

evilrat666 commented 1 year ago

Hi, sorry for late response. I somehow missed notification.

Anyway, doing such version split will likely won't give any significant build time improvements, but will require users to do an extra configuration step. It will also reduce maintainability of affected files and will be easily overlooked in the further updates as this is still manual labor.

If however doing this will provide significant build time reduction(let say 100ms) I'll probably accept such changes. But currently there is no benchmarks and it is hard to tell if it is even worth it.