search

evilru / quake3-vsp-stats

VSP Stats Game Log Processor - updated and working version of vsp-0.45-xp-1.2-full.zip from https://vsp.goquake.com/ as docker image: https://hub.docker.com/r/evilru/quake3-vsp-stats.
MIT License
11 stars 10 forks source link

DB connection fails on certain Docker engine versions #10

Closed alcachofass closed 3 years ago

alcachofass commented 3 years ago

"host.docker.internal" does not resolve on docker-20.10.4-1.amzn2.x86_64 running on Amazon Linux 2 AMI nor on docker-ce-20.10.7-3.el7.x86_64 on CentOS 7.9.2009. However, the service "db" should always resolve correctly through Docker's native DNS ensuring the connection to the DB always succeeds regardless of platform. (This issue does not affect Docker Desktop 20.10.6 on Windows 10 20H2.)

Example of Issue from inside a running instance of quake3-vsp-stats: root@1f262848f947:/vsp# curl host.docker.internal curl: (6) Could not resolve host: host.docker.internal root@1f262848f947:/vsp# curl db curl: (7) Failed to connect to db port 80: Connection refused root@1f262848f947:/vsp#

I'll send you a PR #11 showing how I tackled this on the compose file. I think the same could be accomplished by updating "ENV DB_HOSTNAME" in the Dockerfile.

evilru commented 3 years ago

Thank you for providing this information! I updated the default value of DB_HOSTNAME