search

evilsocket / opensnitch

OpenSnitch is a GNU/Linux interactive application firewall inspired by Little Snitch.
GNU General Public License v3.0
10.92k stars 509 forks source link

opensnitch-ui crashes (aborts) when on_update_triggered is called #197

Closed martynhare closed 6 years ago

martynhare commented 6 years ago

How-I-managed-to-make-this-software-work-patch: fix-abort-on-getpwall.patch.txt

Basically after building opensnitch, I found the UI would crash after every single prompt. I managed to get the software to work by making the attached (above) changes to stats.py

--- First problem --- Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/opensnitch/dialogs/stats.py", line 209, in _on_update_triggered by_users["%s (%s)" % (pw_name, uid)] = hits UnboundLocalError: local variable 'pw_name' referenced before assignment

--- Second problem --- Initialising pw_name earlier on in the code with the default error would get round the first problem but then I'd encounter this instead....

Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/opensnitch/dialogs/stats.py", line 206, in _on_update_triggered pw_name = pwd.getpwall().pw_name AttributeError: 'list' object has no attribute 'pw_name' Aborted (core dumped)

martynhare commented 6 years ago

Oh.. I almost forgot to say thank you by the way. I've been looking for a solution to do per-application outbound filtering on Linux for a while. Good old Douane would kernel panic and although there are some other solutions out there (Subgraph OS firewall), this one seems to be the most simple to deploy.

Once I've gotten my head round some of the code (hint: not been a developer since Uni), I will see if this can be adapted to be packaged for Fedora as an additional firewall option! =D

luzpaz commented 6 years ago

@MartynHare Perhaps you should make a PR from the patch above and mention Closes #197 in the git summary. It's easier to inspect the code instead of downloading the patch and opening it in a text editor etc...

martynhare commented 6 years ago

@luzpaz a very good idea. I will make one and see where things go. Thanks for the suggestion :)

Attached is a proper patch that doesn't break the user list, which will also be added to the pull request.

fix-abort-on-getpwall-v2.patch.txt

MiWCryptAnalytics commented 6 years ago

Also ran into this one, I closed the duplicate PR #202 Could we please merge this, the ui is broken without this fix