search

evilsocket / opensnitch

OpenSnitch is a GNU/Linux interactive application firewall inspired by Little Snitch.
GNU General Public License v3.0
10.74k stars 498 forks source link

"for this session" better wording. #307

Closed themighty1 closed 3 years ago

themighty1 commented 3 years ago

For many days I was under the impression that when in popup I select "for this session" that means "for this process's session" which in my mind means "until this instance of the process quits". It's only when I looked closely at the Rules tab that I realized that it means until system's restart. I suggest that we rename it to "until restart" in the GUI. Or better still "until reboot" because reboot is less ambiguous - it definitely means the whole machine.

xenDE commented 3 years ago

IMHO it's best to use wording from littlesnitch, because I use both.

gustavo-iniguez-goya commented 3 years ago

I agree @themighty1 , internally the action is in fact "until restart"

"until reboot" then? Actually the rules will be valid until restart... the daemon, regardless if you reboot/restart the machine.

gustavo-iniguez-goya commented 3 years ago

What do you think on using the github "forums" to talk about ideas, requests, general help (not issues), etc? This repo doesn't have it enabled, but I enabled it here: https://github.com/gustavo-iniguez-goya/opensnitch/discussions

themighty1 commented 3 years ago

Nice, thanks, discussions is good in some cases. This "better wording" issue is an enhancement, so it is best to keep it here in the issues.

gustavo-iniguez-goya commented 3 years ago

what words should we use for this option? "until restart", "until restart (daemon)", "until reboot", ...

The rules are valid "until restart the daemon".

themighty1 commented 3 years ago

Just to clarify, if the user pauses the daemon from the GUI and then resumes, will the "for this session" rule persist?

gustavo-iniguez-goya commented 3 years ago

Yes, if the daemon is paused, "for this session" rules will persist. In this case, we only stop intercepting new connections, but the daemon remains running.

If daemon is stopped (via systemctl/service), when it starts again it'll ony load the rules from disk. GUI rules are not deleted from the list of the tab Rules.

A feature (or fix) I've been thinking in lately is to synchronize the rules between UI and daemon.

themighty1 commented 3 years ago

So, if the rule persists, then I would go with "until reboot". Since the end-user is not supposed to stop/start opensnitch manually, from his perspective the "for this session" rule will persist until system reboot.