evilsocket / opensnitch

OpenSnitch is a GNU/Linux interactive application firewall inspired by Little Snitch.
GNU General Public License v3.0
10.91k stars 509 forks source link

non disapering qt prompt #67

Closed MarkoShiva closed 7 years ago

MarkoShiva commented 7 years ago

Important bug labeling connection as forever and clicking allow continue prompting you for the same ip all the time. Ways to reproduce: first of all remove all references for firefox in opensnitch.db with sqlitebrowser. start not whitlelisted app for example firefox without proxy then start a ssh connection somewhere which is not blocked which is improvement login via ssh. return back to the firefox prompt and check billion dns prompts that appear no matter if you click forever and allow. 2017-05-12-190501_442x213_scrot click it thousand times it still ain't gonna disappear.

MarkoShiva commented 7 years ago

update once you delete all references for firefox actually prompts appear at least few times when you select forever. For example if you are running privoxy and select forever allow connection of firefox to 8118 it will still ask you 3 times. Also if you have many tabs it will ask you multiple time for the same ip on nonproxified version of firefox.

MarkoShiva commented 7 years ago

2017-05-12-192551_1916x1041_scrot Does this rules look sane too anyone of you that is what happen when I don't open ssh connection that is not blocked in background just when I start regularly firefox? check again where its messed up @adisbladis

adisbladis commented 7 years ago

I had a look of this and the problem is that all connections that are queued are going to show up in the dialog. A normal website load from your browser opens up a whole bunch of connections

We would need to re-check if there has been any rule changes from when the connection was queued before popping up in the UI, that would presumably resolve this.

A related issue (that we are seeing duplicated rules) is that we should add unique constraints to the db. I have created a new issue for this (https://github.com/evilsocket/opensnitch/issues/70).

adisbladis commented 7 years ago

Also it seems like sometimes we are getting multiple callbacks for the same outbound connection. I don't really know why yet..

adisbladis commented 7 years ago

@in1t3r Could you check the behaviour since https://github.com/evilsocket/opensnitch/pull/72 I'm quite interested to know if you are still experiencing issues after that

adisbladis commented 7 years ago

@in1t3r Unless I can get some more info on this soon-ish I'm going to close it since I can't reproduce the described behaviour.

MarkoShiva commented 7 years ago

It is not reproducible anymore after few updates. That was only appearing in the version before queue of messages was not fixed so yeah close the issue.