evilsocket / opensnitch

OpenSnitch is a GNU/Linux interactive application firewall inspired by Little Snitch.
GNU General Public License v3.0
9.92k stars 490 forks source link

UI crash when editing rule due to commit 96cccb8 #766

Closed JeremyMahieu closed 1 year ago

JeremyMahieu commented 1 year ago

Describe the bug UI crashes when the user attempts to edit a rule via context menu item Edit.

Include the following information:

To Reproduce Open Rules list. Select a rule. Right-click to open context menu. Choose Edit.

Post error logs: AttributeError: 'Nodes' object has no attribute '_interfaces'

Expected behavior (optional) Should be able to edit rules.

Additional context https://github.com/evilsocket/opensnitch/blob/a3538a728f8b9adf044fa55963f627dd8d8f2099/ui/opensnitch/nodes.py#L162 _interfaces was used but forgotten to set it up like in utils.py or service.py Solution: add an equivalent of setup_interfaces() function from service.py to init for nodes.py

gustavo-iniguez-goya commented 1 year ago

fixed @JeremyMahieu , thank you!

JeremyMahieu commented 1 year ago

Thanks for the quick fix! 🎉