evilsocket / pwnagotchi

(⌐■_■) - Deep Reinforcement Learning instrumenting bettercap for WiFi pwning.
https://pwnagotchi.ai/
Other
7.71k stars 1.16k forks source link

Refactor Waveshare 1.54 config option value #448

Open chillinPanda opened 5 years ago

chillinPanda commented 5 years ago

In #434 support for the screen was added.

Is your feature request related to a problem? Please describe. It's not a problem now but could be in the future if someone wants to add new types of the display module and must create new config values which might confuse users.

At the moment the value is waveshare154inch but this is for the type B.

What happens if someone else adds support for type C? Then we would have

As of the vendor's website there are three types: https://www.waveshare.com/wiki/1.54inch_e-Paper_Module_(B)

Describe the solution you'd like

Rename option value to waveshare154inch_b

Describe alternatives you've considered None.

Additional context

chillinPanda commented 5 years ago

Hi @ronangaillard ,

what do you think about the option's name?

ronangaillard commented 5 years ago

Perfect, I should have done that myself first I can do a PR tomorrow :)

ronangaillard commented 5 years ago

I'll also update the font sizes to get a better reading on such screens