evilsoft / crocks

A collection of well known Algebraic Data Types for your utter enjoyment.
https://crocks.dev
ISC License
1.59k stars 102 forks source link

Update Writer To Take an Instance instead of a Value #201

Open evilsoft opened 6 years ago

evilsoft commented 6 years ago

Mistakes were Made

When Writer was first created, I thought it would be neat to let the Writer take care of lifting raw values into the underlying Monoid. This created many problems with this Datatype:

This will be a breaking change.

dalefrancis88 commented 5 years ago

Was just reading this, I've yet to use Writer so this will obviously add to my confusion but I'm not sure what the update is that needs to be made. Could we add a Repl that shows the issue?