Update omit function signature

evilsoft / crocks

A collection of well known Algebraic Data Types for your utter enjoyment.

https://crocks.dev

ISC License

1.59k stars 102 forks source link

Update omit function signature #402

Closed zhentian-wan closed 5 years ago

zhentian-wan commented 5 years ago

Looks like omit should take an array of string, instead of just string

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling dfd23eca0d3d271e8fb3d86e58e445f6c597eadc on zhentian-wan:master into 5de30f2ee915abd396793e76f6ef5f86dceb24f1 on evilsoft:master.

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling 91612c2f165e99797520709f476cc78c1d8d4794 on zhentian-wan:master into 5de30f2ee915abd396793e76f6ef5f86dceb24f1 on evilsoft:master.

evilsoft commented 5 years ago

@zhentian-wan sorry I missed this on my first review, but the siggy should also be changed here on the Functions index page.

Also if you want to add yourself to the contributors list, you should run the following in the project root and then commit the changes:

yarn contributors:add zhentian-wan doc

or using npm:

npm run contributors:add zhentian-wan doc

zhentian-wan commented 5 years ago

@zhentian-wan sorry I missed this on my first review, but the siggy should also be changed here on the Functions index page.

Also if you want to add yourself to the contributors list, you should run the following in the project root and then commit the changes:
yarn contributors:add zhentian-wan doc
or using npm:
npm run contributors:add zhentian-wan doc

Thanks :)

evilsoft commented 5 years ago

Merging!

zhentian-wan commented 5 years ago

Thank you so much for getting this in! Here have a squirrel for all your hard work!

Thanks for accepting it :) Thanks for your hard work on crock.js and videos on Youtube and Egghead.io, I have learned a lot from those.