Add Writer docs, minor corrections to Pair docs

evilsoft / crocks

A collection of well known Algebraic Data Types for your utter enjoyment.

https://crocks.dev

ISC License

1.59k stars 102 forks source link

Add Writer docs, minor corrections to Pair docs #468

Closed karthikiyengar closed 4 years ago

karthikiyengar commented 4 years ago

Long overdue PR, very happy to strike this off my to do list! Please take a look guys.

evilsoft commented 4 years ago

Did you want this to go into master or into 0.13.0?

karthikiyengar commented 4 years ago

@evilsoft - I just dropped a commit that makes the docs comply with 0.13. The docs assume that #201 and #105 are merged.

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 5188db6fa2dd837e44a441ddd8ec4550a0c9da71 on writer-docs into a7d46ccf4d75651a2050e49af6e26b41262d0699 on 0.13.

dalefrancis88 commented 4 years ago

@karthikiyengar i think you were right in pointing this to 0.13

karthikiyengar commented 4 years ago

@dalefrancis88 - There we go.

dalefrancis88 commented 4 years ago

@karthikiyengar is this ready for another review? just want to make sure it's not lost

karthikiyengar commented 4 years ago

@dalefrancis88 - I've addressed comments from the previous review.