search

evilsoft / crocks

A collection of well known Algebraic Data Types for your utter enjoyment.
https://crocks.dev
ISC License
1.59k stars 102 forks source link

Output result not correct #472

Closed BasantPandey closed 4 years ago

BasantPandey commented 4 years ago

Identity(42) .valueOf() //=> 42 (Must be 42) not 33

Remove following lines

Identity(20) .concat(Identity(22)) .valueOf() //=> 35

due to this error message. Throwing error "TypeError: Identity.concat: Both containers must contain Semigroups of the same type"

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 483808238736f8c1ecc523336ae25ef630bc47f5 on BasantPandey:patch-1 into ac80421de0b8ddcb525cf35fa97c491f7dd0afea on evilsoft:master.

evilsoft commented 4 years ago

@dalefrancis88 just going to merge this. Looks like all of your comments were addressed.

dalefrancis88 commented 4 years ago

Easy done :)