search

evilsoft / crocks

A collection of well known Algebraic Data Types for your utter enjoyment.
https://crocks.dev
ISC License
1.59k stars 102 forks source link

Update Import path for 'merge' module-name #473

Closed BasantPandey closed 4 years ago

BasantPandey commented 4 years ago

Update import path for 'merge' module-name from 'crocks/Pair/merge' to 'crocks/pointfree/merge'.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e5229ea36c273e4a60ef21eabd79ebc63be5bfb3 on BasantPandey:patch-2 into df5558b7172577f215a7b630870496a5b8dfe31c on evilsoft:master.

evilsoft commented 4 years ago

@BasantPandey Thanks for getting these in. Sorry it took so long to get these going into master.

If you would like, for all the hard work you have done on the docs, feel free to follow these instructions on this PR to add yourself to the Contributors list: https://github.com/evilsoft/crocks/blob/master/CONTRIBUTORS.md#taking-credit

BasantPandey commented 4 years ago

Sorry Post this message too late. I was setting up my dev environment. I got this error and I could not proceed further.

Cannot download "https://github.com/sass/node-sass/releases/download/v4.9.4/win32-x64-67_binding.node":

This file no longer exist in this location.

image

dalefrancis88 commented 4 years ago

I've seen this before when changes have been made to node. Rimraf your node_modules in both docs and root and re-run npm run setup

evilsoft commented 4 years ago

@BasantPandey can you run yarn setup or npm run setup? That should get you a clean install on everything.

Edit: Oh snap, so sorry @dalefrancis88 already mentioned this.

BasantPandey commented 4 years ago

@evilsoft I am using npm and used the same step as mentioned in the document npm run setup https://github.com/evilsoft/crocks/blob/master/CONTRIBUTORS.md#taking-credit.

  1. I used the npm run setup a couple of times but did not worked for me. I will check with Yarn.
evilsoft commented 4 years ago

hmmm. Are you on windows but running it in a linux shell? Looks like you are using bash, but it is expecting something from win64 for the sass binary.

BasantPandey commented 4 years ago

Yes I am using window 10 and running all these commands on windows. Can you quickly check on your machine are you able to run this command on your machine ''"npm i sass@4.9.4'’" successfully?

The error occurred because 4.9.4 versoin no longer exit.

BasantPandey commented 4 years ago

I think I need to check which node version compatible with sass@4.9.4 version. https://github.com/sass/node-sass/blob/master/TROUBLESHOOTING.md#running-with-sudo-or-as-root

BasantPandey commented 4 years ago

It takes lots of time to setup the environment.

  1. Node js 10.13.0 version
  2. Update java SDK inorder to compile .soy files.
BasantPandey commented 4 years ago

Kindly review it and process it. Thanks