search

evilsong / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

glibc 2.16: Invalid conversion in linuxthreads.cc breaks build #444

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Try to compile tcmalloc with glibc 2.16.

What is the expected output?
Compiles.

What do you see instead?
Aborts with:

third_party/tcmalloc/chromium/src/base/linuxthreads.cc: In function ‘void 
ListerThread(ListerParams*)’:
third_party/tcmalloc/chromium/src/base/linuxthreads.cc:312:24: error: invalid 
conversion from ‘void (*)(int, siginfo_t*, void*)’ to ‘void (*)(int, 
siginfo*, void*)’ [-fpermissive]

What version of the product are you using? On what operating system?
Whatever gets shipped with Chromium-git. Arch Linux x64

Please provide any additional information below.
Tested by reverting (exclusively) to glibc 2.15; error failed to appear.

Also posted as Chromium issue: 
https://code.google.com/p/chromium/issues/detail?id=136023

Original issue reported on code.google.com by andreas....@gmail.com on 5 Jul 2012 at 9:20

GoogleCodeExporter commented 9 years ago 
Changing line 312 from
static void SignalHandler(int signum, siginfo_t *si, void *data) {
to
static void SignalHandler(int signum, siginfo *si, void *data) {
seems to fix the problem

Original comment by rgg...@gmail.com on 7 Jul 2012 at 7:06

GoogleCodeExporter commented 9 years ago 
Indeed. Successfully compiled it with that change; no issues so far. Thanks for 
the hint.

Original comment by andreas....@gmail.com on 7 Jul 2012 at 4:39

GoogleCodeExporter commented 9 years ago 
For Arch's Chromium package I replaced 'struct siginfo' with siginfo_t in 
third_party/tcmalloc/chromium/src/base/linux_syscall_support.h. (Similarly to 
http://patchwork.ozlabs.org/patch/169170/)

Patch attached.

Original comment by evange...@foutrelis.com on 12 Jul 2012 at 1:50

Attachments:

GoogleCodeExporter commented 9 years ago 
Any update on this?

Original comment by pipping....@gmail.com on 10 Sep 2012 at 5:21

GoogleCodeExporter commented 9 years ago

Original comment by chapp...@gmail.com on 3 Nov 2012 at 4:57

GoogleCodeExporter commented 9 years ago 
r176 | chappedm@gmail.com | 2012-11-04 13:24:46 -0500 (Sun, 04 Nov 2012) | 2 
lines

issue-444: Fix for invalid conversion build error in signal handler code

Original comment by chapp...@gmail.com on 4 Nov 2012 at 6:25

GoogleCodeExporter commented 9 years ago 
new version for patch

Original comment by madein272766 on 23 Dec 2012 at 8:32

Attachments:

GoogleCodeExporter commented 9 years ago 
Isn't this the same patch that was previously submitted?

Original comment by chapp...@gmail.com on 23 Dec 2012 at 8:37

GoogleCodeExporter commented 9 years ago 
pardus chromium previous patch the operating system 'not fit. (google translete 
with)

Original comment by madein272766 on 23 Dec 2012 at 8:49

GoogleCodeExporter commented 9 years ago 
Issue 485 has been merged into this issue.

Original comment by chapp...@gmail.com on 11 Mar 2013 at 11:33