[patch] Wrong instruction on PPC64 CAS primitive

evilsong / gperftools

Automatically exported from code.google.com/p/gperftools

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

[patch] Wrong instruction on PPC64 CAS primitive #445

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

The current 'OSAtomicCompareAndSwap64' uses the instruction 'cmpw' which only 
compares the high half of a 64-bits register. Since the function operates on 
Atomic64, it should use 'cmpd' instead.

Patch included and tested on PPC64.

Original issue reported on code.google.com by zatr...@gmail.com on 10 Jul 2012 at 1:31

Attachments:

gperftools-ppc64-cas.patch

GoogleCodeExporter commented 9 years ago

Original comment by chapp...@gmail.com on 3 Nov 2012 at 4:56

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

r177 | chappedm@gmail.com | 2012-11-04 13:30:05 -0500 (Sun, 04 Nov 2012) | 2 
lines

issue-445: Fix for wrong cmpx instruction in OSAtomicCompareAndSwap64 for ppc64

Original comment by chapp...@gmail.com on 4 Nov 2012 at 6:30

Changed state: Fixed