evilsong / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

[PATCH] Add support to timebase value for PPC64 #455

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Back in 2009 I reported I got a better performance using a different size for 
large pages on PPC32/PPC64 
(https://groups.google.com/d/topic/google-perftools/h9ecjfjiK20/discussion). 
Based on that, I'm proposing a patch to add another size to large pages in 
tcmalloc through a new define (TCMALLOC_LARGE_PAGES64K). Tested on ppc32 and 
ppc64.

Index: src/common.h
===================================================================
--- src/common.h        (revision 149)
+++ src/common.h        (working copy)
@@ -64,6 +64,9 @@
 #if defined(TCMALLOC_LARGE_PAGES)
 static const size_t kPageShift  = 15;
 static const size_t kNumClasses = 78;
+#elif defined(TCMALLOC_LARGE_PAGES64K)
+static const size_t kPageShift  = 16;
+static const size_t kNumClasses = 82;
 #else
 static const size_t kPageShift  = 13;
 static const size_t kNumClasses = 86;

Original issue reported on code.google.com by zatr...@gmail.com on 25 Jul 2012 at 4:23

GoogleCodeExporter commented 9 years ago
My bad: the title for this patch should be "New size for Large Pages".

Original comment by zatr...@gmail.com on 25 Jul 2012 at 4:26

GoogleCodeExporter commented 9 years ago
Patch applied and committed to the main trunk.

------------------------------------------------------------------------
r155 | chappedm@gmail.com | 2012-09-17 20:59:16 -0400 (Mon, 17 Sep 2012) | 1 
line

issue-455: Adds another size for large pages in tcmalloc through the new define 
TCMALLOC_LARGE_PAGES64K
------------------------------------------------------------------------

Original comment by chapp...@gmail.com on 18 Sep 2012 at 1:00