search

evilsong / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Would be good to enable reuse of SideStep (windows/preamble_patcher.h et al.) in other projects #551

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I'm the original author of the preamble patcher implementation used in Windows 
(windows/preamble_patcher.h and related files).  Currently it is tied to 
gperftools only through the various SIDESTEP_XYZ macros.

It would be good if the definition of these macros could be made such that 
other projects could reuse the SideStep code and provide their own definition 
of these macros.

Original issue reported on code.google.com by joi@chromium.org on 17 Jul 2013 at 7:37

GoogleCodeExporter commented 9 years ago 
Here is the patch I made for this small change. Hope you time to review it =)

Original comment by olidarkn...@gmail.com on 17 Jul 2013 at 7:49

Attachments:

GoogleCodeExporter commented 9 years ago 
Hm. Are you sure you haven't forgot to add sidestep_config.h to the patch ?

Original comment by alkondratenko on 18 Jul 2013 at 4:54