search

evilstreak / markdown-js

A Markdown parser for javascript
7.69k stars 863 forks source link

Consistently use double quotes when possible. #120

Closed XhmikosR closed 10 years ago

XhmikosR commented 10 years ago

Ping me after merging the other PRs so that I update this one.

Unfortunately, enabling JSHint's rule to enforce one quotes style, results in many warnings which I'm not sure anyone should bother at this point. But I can enable it if you agree.

XhmikosR commented 10 years ago

PR updated

evilstreak commented 10 years ago

I'm happy with these changes but I don't think it's worthwhile merging them unless we can enforce use of double quotes via the test suite.

If you're able to fix the problem that JSHint's rule causes please reopen this PR.

XhmikosR commented 10 years ago

Ofc we can. I simply didn't enforce double quotes because tests need some work. I will update the PR tomorrow and let someone else deal with the failing JSHint issues.

XhmikosR commented 10 years ago

I can't reopen the PR myself, but I updated the branch. Tests will fail, feel free to merge and fix the remaining issues.