search

evilstreak / markdown-js

A Markdown parser for javascript
7.7k stars 863 forks source link

grunt jshint against lib/markdown.js? #123

Closed XhmikosR closed 11 years ago

XhmikosR commented 11 years ago

Shouldn't the jshint task run for the lib/markdown.js file instead of the individual src files?

/cc @eviltrout

ashb commented 11 years ago

Do you mean run the tests against the output file rather than the source files?

XhmikosR commented 11 years ago

Yeah. Or maybe we should do it for both?

ashb commented 11 years ago

I couldn't give two hoots about the styling of a generated file - it's no longer under source control so I don't see we get any benefit of checking the style of this file.

XhmikosR commented 11 years ago

I don't care about its styling either. But, it's the actual code used after all.

So instead of checking all 11 source files, we could just check the one, final, generated js file.

ashb commented 11 years ago

If we checked the generated file it would be hard to track down what line needs changing in file under src/, and/or duplicate the warning.

XhmikosR commented 11 years ago

That is true, indeed.

I'll close the issue then.