evilstreak / markdown-js

A Markdown parser for javascript
7.69k stars 863 forks source link

Supports blockquotes prefixed by spaces #133

Closed eviltrout closed 10 years ago

eviltrout commented 10 years ago

Currently markdown-js doesn't support blockquote characters prefixed by spaces. So > hello' works but > hello` does not. This functionality should work if we're going by the web dingus for markdown.

This patch adds a little scrubber to the blockquote functionality to support spaces in front. It also includes a test to make sure that if there enough spaces a code block will come into effect.

ashb commented 10 years ago

Confirmed: http://babelmark.bobtfish.net/?markdown=++%3E+evil

(I'll look at merging this and most of the outstanding pull requests this weekend I hope.)

evilstreak commented 10 years ago

Should the code block tests be called with_greater_than rather than with_less_than?

eviltrout commented 10 years ago

Yes, I'll fix that :)

eviltrout commented 10 years ago

Renamed to with_greater_than