evilstreak / markdown-js

A Markdown parser for javascript
7.69k stars 863 forks source link

Updates grunt-node-tap so we have nicer output when feature tests fail #179

Open eviltrout opened 10 years ago

evilstreak commented 10 years ago

I think this version of grunt-node-tap caused this issue: https://github.com/evilstreak/markdown-js/issues/174

eviltrout commented 10 years ago

That error seemed about 1.4.5, this one is 1.5.2; locally I can run the default grunt task and everything works (with nicer output!). Maybe give it a shot locally and let me know if it's a problem?

ashb commented 10 years ago

This works for me, but then pinning at version 0.1.48 which seemed to be the problem previously doesn't fail for me anymore

@jherdman Can you try this branch and let us know if npm test works for you with this?

jherdman commented 10 years ago

npm test works fine, but grunt does not.

eviltrout commented 10 years ago

What errors are you getting in grunt? Grunt works totally fine for me with this version.

On Thu, Feb 20, 2014 at 2:33 PM, James Herdman notifications@github.comwrote:

npm test works fine, but grunt does not.

Reply to this email directly or view it on GitHubhttps://github.com/evilstreak/markdown-js/pull/179#issuecomment-35659891 .

jherdman commented 10 years ago

Fatal error: spawn ENOENT (stack trace is linked)

ashb commented 10 years ago

I see the same:

% ./node_modules/.bin/grunt all
Running "node_tap:default_options" (node_tap) task
Fatal error: spawn ENOENT

Interestingly:

% PATH=./node_modules/.bin/:$PATH ./node_modules/.bin/grunt
Running "node_tap:default_options" (node_tap) task
Stats: ./test/features.t.js: 196/196
Stats: ./test/html_renderer.t.js: 2/2
Stats: ./test/interface.t.js: 3/3
Stats: ./test/regressions.t.js: 83/83
...

That works. What on earth is grunt-node-tap doing?

ashb commented 10 years ago

I have raised an issue with grunt-node-tap - lets see if the author of it has any insights.

eviltrout commented 10 years ago

That's so strange. I just confirmed again that both npm test and grunt all work correctly. It must be some kind of platform issue.

I'm on node v0.10.24

jherdman commented 10 years ago

I'm on Node v0.10.26 on OS X if that helps.