search

evilstreak / markdown-js

A Markdown parser for javascript
7.7k stars 863 forks source link

Audio/video support #183

Closed Hermanya closed 10 years ago

Hermanya commented 10 years ago

I've added a way to insert audio and video tags. It works just the way images do, only Alt text attribute should by either "audio" or "video".

Hermanya commented 10 years ago

This is my first pull request, I had no idea that enter sends the comment instead of adding a new line. So, it works just the way images do, only Alt text attribute should be either "audio" or "video" in order to become not an image.

ashb commented 10 years ago

Sorry for leaving this open for so long - open source is hard :/

I'm going to say that this doesn't belong in the core distribution - the core should be just the tools to build other dialects and one or two widely used dialects.

There are other dialects on npm that you should be able to use as an example on how to create your own. Let us know if you need some pointers.