search

evilstreak / markdown-js

A Markdown parser for javascript
7.69k stars 863 forks source link

FIX: Error when linking to absolute URLs with absolute links to images #207

Open eviltrout opened 9 years ago

eviltrout commented 9 years ago

Matching URLs with regular expressions is tough! However, this approach fixes issues when linking to absolute URLs with absolute image URLs inside them.

ashb commented 9 years ago

At times I wish I hadn't built this around regexps :( That :ship: has long since sailed.

Change looks okay - could you look at what happened to the node 0.8 tests in travis?

eviltrout commented 9 years ago

Looks like a random npm failure to me? I didn't change any deps.

ashb commented 9 years ago

Hmmmm its seemed to have been failing for about a month https://travis-ci.org/evilstreak/markdown-js/pull_requests

Bet its some annoyance in a dep that no longer supports node.js 0.8.... Bah.

So we either need to pin grunt (at a guess) to an older version, or drop support for 0.10... thoughts either way?

eviltrout commented 9 years ago

We only use it in browsers so I have no insight into node versions. But 0.8 is quite old isn't it?