link Images require a title tag

evilstreak / markdown-js

A Markdown parser for javascript

7.69k stars 863 forks source link

link Images require a title tag #71

Closed parmleyhunt closed 10 years ago

parmleyhunt commented 11 years ago

[![alt](src "title")](link)

should also be able to only be

[![alt](src)](link)

parmleyhunt commented 11 years ago

There are too many white-space courtesies, one of them is not being optionalized when the tag does not appear and that is what's causing it to fail. However when i try to escape one of the existing it also fails, or it doesn't allow a tag. I also tried putting in a second check for without a tag, and that still failed. Currently if you have a trailing space, but no tag it will still work.

evgenyneu commented 11 years ago

I noticed this bug as well.

ashb commented 10 years ago

Fixed by another change in ecf34ff9, test added in e1813a2d